commit | f2bff73ff3861f8acc968a6be7c7879d51638e80 | [log] [tgz] |
---|---|---|
author | Mohamed Amir Yosef <mamir@chromium.org> | Fri Jan 25 13:48:17 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 25 13:48:17 2019 |
tree | 443e992a89a66437053db17b63504c2197d0325e | |
parent | 4493758b86c37af1c8f22dffa7dbc30766b7aa69 [diff] |
[Sync::USS] Add NOTIMPLEMENTED methods to PasswordStoreX Recently introduced methods in PasswordStoreSync interface are implemented in PasswordStoreDefault. However, this implementation isn't compatible with PasswordStoreX. This overrides such methods in PasswordStoreX with a NOTIMPLEMENTED() implementation to make sure they aren't called by mistake. This should be OK because those methods are only used in Sync code base which doesn't use PasswordStoreX. In addition, PasswordStoreX will be deprecated. Similarly implementation in used in TestPasswordStore because it doesn't support primary key for forms. This is also OK because Sync unittest is using a mock PasswordSyncStore rather than a TestPasswordStore. Bug: 902349 Change-Id: Id795f3f6ae6b0efa75bbb22dc1675f3c12210692 Reviewed-on: https://chromium-review.googlesource.com/c/1429964 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626067}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .