Google Git
Sign in
chromium / infra / infra / f2c71274458177b488027fdd9b3d0cbd384540ef
commitf2c71274458177b488027fdd9b3d0cbd384540ef[log] [tgz]
authorScott Lee <ddoman@chromium.org>Wed Jan 06 09:13:32 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 06 09:13:32 2021
treec7c6f40b47ff74b0426a6f54db445f0ba59d06e9
parent8e3415be1444041241c0b74b3d374d04cd597087 [diff]
Revert "[gae_ts_mon] Replace Modules API with environment variables for py3 compatibility"

This reverts commit 36c7b6704d17dbd1c7ee6f157040813eb7bda761.

Reason for revert: broke unit tests - crbug.com/1163440

Original change's description:
> [gae_ts_mon] Replace Modules API with environment variables for py3 compatibility
>
> Bug: monorail:8841
> Change-Id: I1c63e38191ea1983bc075360fe8a3220926f22c9
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2611839
> Commit-Queue: Kevin Weng <kweng@google.com>
> Reviewed-by: Dave Tu <dtu@chromium.org>
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#37311}

TBR=dtu@chromium.org,ddoman@chromium.org,kweng@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ie717380459724c5b9a4daa096e00f7f17c5e4c3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: monorail:8841
Bug: 1163440
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2612904
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#37320}
4 files changed
tree: c7c6f40b47ff74b0426a6f54db445f0ba59d06e9
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.