Google Git
Sign in
chromium / infra / infra / f2d50a421f9796f3493b96d96b3f56dc78dceb73
commitf2d50a421f9796f3493b96d96b3f56dc78dceb73[log] [tgz]
authorAnushruth <anushruth@chromium.org>Tue Apr 06 20:50:31 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 06 20:50:31 2021
treeb518705cdb2cd95e1169687ead2f7d99c059dbba
parentaf052dbb407e4ee32dd965084fbd0ae585f7196b [diff]
[Skylab]: Remove inventory and internal cmds

Bug: 1171987
Test: tested remaining commands for sanity

Removes the following commands from skylab tool. This is done as the
support for these operations is migrated to skylab.
1. add-dut                   add a new DUT
2. add-labstation            add a new labstation, batch deploy option is also supported
3. validate-new-dut-json     validate json for a new DUT
4. remove-duts               remove DUTs from the inventory system
5. update-dut                update an existing DUT
6. batch-update-duts         update a fixed set of common labels for a batch of existing DUTs
7. update-labstation         update a labstation
8. internal-list-drone-duts  list DUTs for a drone

Change-Id: I9ebfbb9f83f3e1f3ebcca14d8b61cdc12e1cd417
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2785493
Commit-Queue: Anushruth  <anushruth@chromium.org>
Reviewed-by: Eshwar Narayan <eshwarn@chromium.org>
Reviewed-by: Otabek Kasimov <otabek@google.com>
Reviewed-by: Gregory Nisbet <gregorynisbet@google.com>
Cr-Commit-Position: refs/heads/master@{#39948}
11 files changed
tree: b518705cdb2cd95e1169687ead2f7d99c059dbba
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.