commit | f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9 | [log] [tgz] |
---|---|---|
author | Florent Castelli <orphis@chromium.org> | Fri Oct 12 08:33:39 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 12 08:33:39 2018 |
tree | 3f8b52e4225ece291f1a23d2a3a610d621306244 | |
parent | 4cb84b573a62d8db8d168de16560b4ff78df5bda [diff] |
Revert "Move InstallAttributes to chromeos/settings" This reverts commit aa6c62dce936e966e2db445045dd04414553642b. Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402 Original change's description: > Move InstallAttributes to chromeos/settings > > Necessary for moving CrosSettings to chromeos/settings, so it > can eventually be used by Mustash. > > The following changes were necessary: > 1. Move install_attributes{.h, .cc} and unit_test.cc > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn > (destination) > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h, > which is included by install_attributes.h > > 4. Unfortunately, that same dependency lead to a circular dependency. > I was able to avoid that by separating out a "common_constants" rule in > components/policy/core/common, so that chromeos/settings only depends on > that, and not on all of components/policy. So I had to change > components/policy/core/common/BUILD.gn > and I removed an unnecessary include from > components/policy/core/common/cloud/cloud_policy_constants.cc > > 5. Update #include directives for install_attributes to point to new > location. This is the other 22 files, all with diffs of +1 -1. > > Bug: 446937 > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288 > Reviewed-on: https://chromium-review.googlesource.com/c/1264757 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: A Olsen <olsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599140} TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org Change-Id: I50c58b55830961d97834d86a76088dc50eff672d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 446937 Reviewed-on: https://chromium-review.googlesource.com/c/1278748 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599143}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .