commit | f3878c07b1c5501e27ea0964d8a0ba0196cf7680 | [log] [tgz] |
---|---|---|
author | bsheedy <bsheedy@chromium.org> | Wed Jan 30 08:08:56 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 30 08:08:56 2019 |
tree | 7f0c7de29979dd6b5e876ea0fadfa4ab1143c002 | |
parent | 4552576c7619e2ff14e645023df59bdda0001138 [diff] |
Fix ClearBrowsingDataPreferencesTest on O+ Changes the way that ClearBrowsingDataPreferencesTest disables the automatic granting of notification permissions to the default search engine. Previously, it tried to manually set the permission to blocked, which didn't work on O+ due to it automatically granting the permission unconditionally as long as the GrantNotificationsToDSE feature was enabled, causing a DCHECK to be hit due to attempting to change the notification channel from allowed to blocked. Instead, simply disable the feature that causes the DSE to get notification permissions via the command line. Also drive-by changes the EmbeddedTestServer usage to use the one provided by the test rule that's automatically spun up and cleaned up instead of trying to manage it manually within the test. Bug: 884413 Change-Id: I23867c3374966a9cca4112d614a4710565717096 Reviewed-on: https://chromium-review.googlesource.com/c/1444755 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#627349}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .