Google Git
Sign in
chromium / chromium / src / f456aeefda399d09d0641f7670ebeabdad24e609
commitf456aeefda399d09d0641f7670ebeabdad24e609[log] [tgz]
authordanakj <danakj@chromium.org>Wed Jan 09 20:34:46 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jan 09 20:34:46 2019
tree7454f12b54a63de6693afa6cf09caf08b617370a
parentc1f53302c724ff117d5589a830cc049f28393b4f [diff]
Move Page into the WebView portion of WebViewImpl.

Accessors of it grab it through AsView(). After this we will start to
add guards to prevent AsView() calls inside WebWidget API methods.

1st open question is if WebWidget APIs should be able to access the
main frame and if so if it should be through the WebView/Page or
elseways.

2nd open question is if WebView APIs using the Page should be allowed
to touch the frames (and frame views) at all.

R=dcheng@chromium.org

Change-Id: I141e5660d48ae5b3227aed8525e6f6999c6f6413
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1399742
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621292}
2 files changed
tree: 7454f12b54a63de6693afa6cf09caf08b617370a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .