| commit | f45bbb86ef56073b25e500f21030ebc9f12f96ad | [log] [tgz] |
|---|---|---|
| author | Andreas Haas <ahaas@chromium.org> | Tue Apr 24 10:45:11 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Apr 25 14:23:53 2018 |
| tree | 15d8e43a874d4b76d8b04a63bbb6f0bda895ffaf | |
| parent | e71ed0d6da7d72bb73997d1446d6661eec1bb6ed [diff] |
Merged: [wasm] Call AsyncInstantiate directly when instantiating a module object WebAssembly.instantiate is polymorphic, it can either take a module object as parameter, or a buffer source which should be compiled first. To share code between the two implementations, the module object was first passed to a promise (i.e. which is the result of compilation). However, passing the module object to a promise has a side effect if the module object has a then function. To avoid this side effect I remove this code sharing and call AsyncInstantiate directly in case the parameter is a module object. R=​mstarzinger@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECK=true Bug: chromium:836141 Change-Id: I67b76d0d7761c5aeb2cf1deda45b6842e494eed4 Reviewed-on: https://chromium-review.googlesource.com/1025774 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#52755}(cherry picked from commit 49712d8acf1b16d8d36a6f95ae7e97210a559a45) Reviewed-on: https://chromium-review.googlesource.com/1027876 Cr-Commit-Position: refs/branch-heads/6.7@{#34} Cr-Branched-From: 8457e810efd34381448d51d93f50079cf1f6a812-refs/heads/6.7.288@{#2} Cr-Branched-From: e921be5c4f2c6407936bde750992dedbf47c1016-refs/heads/master@{#52547}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.