commit | f5098f9ce5eca871e28121d1e11be0defc765499 | [log] [tgz] |
---|---|---|
author | Dave Tu <dtu@google.com> | Mon Apr 05 03:27:39 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 05 03:27:39 2021 |
tree | 373b504af52dd789f02502cd1bc9138b5c306018 | |
parent | a0e4d137f588f746115a08c8e81635f614070576 [diff] |
🚝 Add @material-ui/core and react-redux to Monorail deps. This is everything we need to use React and TypeScript in Monorail. Using @material-ui v5.0.0-alpha because Autocomplete is promoted from @mui/labs to @mui/core in v5. This also gives us a little futureproofing against having to migrate from v4 to v5 in the future. Bug: monorail:8931 Change-Id: I1f4efe23bdefd35be6590d07d0787c9827dac565 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2801276 Reviewed-by: Kevin Weng <kweng@google.com> Commit-Queue: Dave Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#39893}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.