| commit | f527e8602d8b4cb18c973d143cb6e33cb4ea6922 | [log] [tgz] |
|---|---|---|
| author | jungkee.song <jungkee.song@samsung.com> | Tue Jan 19 02:51:23 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Jan 19 02:53:40 2016 |
| tree | da840070fca2a5c3feb7765c9df17f2cd5362985 | |
| parent | e7df09b4a3b1370dda95e11625d9dbdb1bfb99a4 [diff] |
Service Worker: (Re-commit) Add FetchEvent.clientId * The original CL was committed but reverted due to a use-of-uninitialized-value report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the original CL with a patch that initializes the member, |is_main_resource_load|, in its containing object's constructors. Changes from the original commit: - Add the member init in the initializer list of the constructors of ServiceWorkerFetchRequest class (in service_worker_types.cc). -- As per the latest spec update, this CL implements FetchEvent.clientId attribute. Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898 Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-clientid Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk The layout tests for this CL are mostly taken from Mozilla's work instead of making new ones to ensure compatibility: https://bugzilla.mozilla.org/show_bug.cgi?id=1222464 BUG=552309 Review URL: https://codereview.chromium.org/1597383002 Cr-Commit-Position: refs/heads/master@{#370073}