commit | f5b5c5cd80975a0b22cef102a06cab8e35bd730a | [log] [tgz] |
---|---|---|
author | Dmitry Gozman <dgozman@chromium.org> | Thu Feb 07 00:32:32 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Feb 07 00:32:32 2019 |
tree | 65632943e23b5b71e7f882708d1712a198035ebe | |
parent | ba28a4588b46cd1c9e9d8edcea6d5e5a2c9eba6d [diff] |
Preload mhtml document before committing a navigation This patch makes RenderFrameImpl load the full mhtml response body before trying to commit it. This is required for synchronous commit (see doc linked to the bug, steps 8.a and 8.b), because we have to parse the archive to retrieve the main resource and its mime type and commit a correct document type. Brief summary: - Introduced MHTMLBodyLoader which consumes data from existing NavigationBodyLoader and puts it all to WebNavigationParams. - Split RenderFrameImpl::CommitNavigationWithParams from CommitNavigationInternal so that we can commit mhtml after loading the response asynchronously. Most of the time we just call CommitNavigationWithParams synchronously. - DocumentLoader now tries to commit mhtml synchronously, and loads empty document if that fails (similarly to archive parsing failure). Bug: 855189 Change-Id: Id27a4e593c1586e1f48591ee0685fdb93aaf8827 Reviewed-on: https://chromium-review.googlesource.com/c/1408351 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629802}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .