| commit | f60b4eb00abc12a1fa2575890f7c77b373a1bedc | [log] [tgz] |
|---|---|---|
| author | dgozman <dgozman@chromium.org> | Wed Jun 22 17:10:53 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Jun 22 17:13:22 2016 |
| tree | d9d228fe1550d596159c67a0c80597d10d4ddd6f | |
| parent | 192d78833ff9297c754f59f20cb4e590d693a7c2 [diff] |
Revert of Make previousLinePosition() not to use dangling RootInlineBox (patchset #1 id:1 of https://codereview.chromium.org/2082893005/ ) Reason for revert: New test editing/selection/modify_move/move_backward_line_import_crash.html fails on WebKit Linux MSAN. Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fselection%2Fmodify_move%2Fmove_backward_line_import_crash.html&testType=webkit_tests First failed build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/10718 Original issue's description: > Make previousLinePosition() not to use dangling RootInlineBox > > This patch makes |previousLinePosition()| not to use dangling |RootInlineBox| > pointer to avoid use-after-free. > > Before this patch, |isEditablePosition()| is called with |DoUpdateStyle| > parameter to update layout tree if needed. Usually, layout tree isn't updated > by this |isEditablePosition()| call since |previousLinePosition()| updates > layout tree at entry. However, if there are pending style sheet, e.g. @import > directive, and HTML import, e.g link rel=import, layout tree is updated since > document isn't rendering ready, |haveImportLoaded()| && > |haveRenderBlockingStyleSheetsLoaded()|. > > BUG=618237 > TEST=LayoutTests/editing/selection/modify_move/move_backward_line_import_crash.html > > Committed: https://crrev.com/fb81c66590538c2487a34b8623066a22d0b27dff > Cr-Commit-Position: refs/heads/master@{#401231} TBR=yoichio@chromium.org,yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618237 Review-Url: https://codereview.chromium.org/2084913005 Cr-Commit-Position: refs/heads/master@{#401319}