commit | f63136f8c4f7d0246552b4383d24ff39f9d22d64 | [log] [tgz] |
---|---|---|
author | Scott Violet <sky@chromium.org> | Thu Aug 09 05:07:19 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 09 05:07:19 2018 |
tree | 4f11c52ef9fe90fff1b868a679bdb4d7cfa0fc32 | |
parent | 3882e0ffa9cba6dd8b608d31f082d7a56a362cad [diff] |
Reland "views: changes test to not use equality" This reverts commit 3882e0ffa9cba6dd8b608d31f082d7a56a362cad. Reason for revert: *SIGH* reverted wrong revert, relanding. Original change's description: > Revert "views: changes test to not use equality" > > This reverts commit 72a83a6c2276e5afcec4f87f2edad760a4809a20. > > Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert. > > Original change's description: > > views: changes test to not use equality > > > > This test was assuming a newly created Window got a pointer value different > > than one recently destroyed. For whatever reason my recent patch made it more > > likely (on the msan bot) that the newly created pointer got the same value as > > the one destroyed, leading to failure. > > > > I'm converting the test to verify the window is destroyed using a WindowTracker. > > > > BUG=847992 > > TEST=covered by tests > > > > Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7 > > Reviewed-on: https://chromium-review.googlesource.com/1168466 > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Commit-Queue: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581788} > > TBR=sky@chromium.org,msw@chromium.org > > Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847992 > Reviewed-on: https://chromium-review.googlesource.com/1168762 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581791} TBR=sky@chromium.org,msw@chromium.org Change-Id: I3f26795a5a5959ad38949cc451591f34539f2141 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847992 Reviewed-on: https://chromium-review.googlesource.com/1168763 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581792}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .