commit | f634ccd9c814489b06fe58263e59ecbf55527cb2 | [log] [tgz] |
---|---|---|
author | Kenichi Ishibashi <bashi@chromium.org> | Tue Jan 08 05:22:55 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 08 05:22:55 2019 |
tree | d389cb6a7621961b06a904451bfa762944ed1b4f | |
parent | 88aaac6e85b3c40f1de98e1b00e68c39d8c64ea1 [diff] |
service worker: Fix fetch timing UMA recording for subresource loading Before this CL there was a path in ServiceWorkerSubresourceLoader where we called RecordTimingMetrics(true) even when the request fell back to network. Specifically: OnFallback() -> CommitEmptyResponseAndComplete() -> CommitCompleted() -> RecordTimingMetrics(true) This generated bogus numbers for ServiceWorker.LoadTiming.Subresource.ResponseReceivedToCompleted2. This CL fixes it by updating CommitCompleted() to check a flag that indicates that network fallback was requested. Bug: 877972 Change-Id: Ia944903938b8a7daed1665475f4b2a871f2b21ab Reviewed-on: https://chromium-review.googlesource.com/c/1397504 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#620631}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .