| commit | f69d2267d8c7c45f1cbb8a7f4617e5ac1dfdaef2 | [log] [tgz] |
|---|---|---|
| author | Samuel Huang <huangs@chromium.org> | Wed Nov 11 22:50:38 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 11 22:50:38 2020 |
| tree | e2e57909ed247660d0fba2469d62856c66d7033d | |
| parent | b35cddfe86b991cc6ee422c2b8e449d4bfbf9333 [diff] |
[Binary Size] Transition to size_config_json flow.
Previously the binary_size recipe has two ways to specify SuperSize main
file and mapping files:
* Old flow: Using android.{apk_name, mapping_names}.
* New flow: Using size_config_json.
This CL removes the old flow and activates the new flow. The default
size config JSON in config/MonochromePublic_size_config.json (under
Chromium output directory) specifies the same input files as before.
This change also activates the usage of new command line arguments in
size scripts
generate_commit_size_analysis.py,
trybot_commit_size_checker.py,
thereby allowing old command line arguments to be removed.
The normal_significant_binary_package_restructure test is updated to
perform override_analyze(), so that the test better reflect the effects
of version string change.
Bug: 1040645
Change-Id: I1dd6ea6cd22705b5e2e4fd41962f6efb028bc860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2527713
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.