| commit | f74ad40ca3b710c48118f3bb76d9698e329f5595 | [log] [tgz] |
|---|---|---|
| author | Garrett Beaty <gbeaty@chromium.org> | Wed Apr 07 18:12:07 2021 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 07 18:12:07 2021 |
| tree | c69041abae35920c92398935a805f4e560135439 | |
| parent | 33a6e16dbc6c265ae805b6c0c7722377959c3322 [diff] |
Remove the builder_id property from BotMetadata. The BotMetadata doesn't really pull its weight: the distinction between settings and config is unclear and the config (the try spec) could just as easily be stored within the BotConfig. It doesn't make sense for BotConfig to have a builder ID since findit builders construct try specs on the fly corresponding to sets of mirrors that don't necessarily match anything in trybots.py Instead operations that require a builder ID have been updated to take the builder ID as a parameter. Follow-up CLs will remove BotMetadata and move the necessary functionality to BotConfig. Bug: 1193832 Change-Id: Ia616e7aebb147832cbbf47c98722e5170f9de59b Recipe-Manual-Change: chrome_release Recipe-Manual-Change: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2809253 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.