commit | f7521461110ddf1ccda31beecdf43eda18391805 | [log] [tgz] |
---|---|---|
author | Zhiqiang Zhang <zqzhang@google.com> | Wed Sep 19 22:22:56 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 19 22:22:56 2018 |
tree | 3471e4a3ed9c210432dc3be2c3acd82973cf0a3e | |
parent | 1287062f782551b52676553d89199811d0da3eb4 [diff] |
[Android MR] Properly treat route close and termination Previously we always notify route termination upon route close, and only notify route close on error. This was because we rely on a separate disconnect_session message to update state in the Web sender SDK. Now as the Web sender SDK solely depend on the PresentationConnection state, we just notify the route state change. The method mapping of before -> after is: * onRouteClosed() -> onRouteTerminated * onRouteClosedWithError() -> onRouteClosed Non-CAF code doesn't have behavioral change. TBR=mlamouri@chromium.org Bug: 711860 Change-Id: I501b9c3b94aba4d4a2f900bf8eba9d8b8179ccab Reviewed-on: https://chromium-review.googlesource.com/1229194 Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592576}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .