commit | f754c5830c9a52b454118303c4dceef3bc98e820 | [log] [tgz] |
---|---|---|
author | Prakhar <pasthana@google.com> | Tue Mar 23 17:07:27 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 23 17:07:27 2021 |
tree | 244c3e5caad9499e59d8894aefc5d592234162b5 | |
parent | d19f1551b5ace99b6e3497bf2dfba663a87ef7de [diff] |
Return valid response in case only unit test coverage is avaiable for a patch Bug: 1016925 Change-Id: Ib91ac1a588b19d5bf2b09a09dfeae3591d8bfc80 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2781111 Reviewed-by: Prakhar Asthana <pasthana@google.com> Reviewed-by: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#39642}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.