commit | f76599dba2ca6e3d87cd9d6a8c9b63eed1a34957 | [log] [tgz] |
---|---|---|
author | Sean Abraham <seanabraham@chromium.org> | Mon Dec 07 22:27:15 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Dec 07 22:27:15 2020 |
tree | 549f9ac7beb1a7eaeecf638e0f3ed1e392d04bbf | |
parent | a8352483e54e2c133090c48128817389901f8880 [diff] |
prototype-rts: address suggestions from https://crrev.com/c/2570006 BUG=chromium:1127071 TEST=local runs Change-Id: I26d33d47eca6dd4972cf51a274fe5aafafe6fd31 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2575565 Commit-Queue: Sean Abraham <seanabraham@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@google.com> Cr-Commit-Position: refs/heads/master@{#36938}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.