commit | f841ac2afe7ac227b760d0300f2abfbe4c278bae | [log] [tgz] |
---|---|---|
author | Jüri Valdmann <juri.valdmann@qt.io> | Fri May 18 22:36:28 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri May 18 22:36:28 2018 |
tree | 45f056561164caacb569b9877aba95daf33eec83 | |
parent | 1a9ca2450be18e04819f358542e19610a2c342ea [diff] |
Mark base::*Callback, GURL and mojo::ScopeHandleBase as noexcept movable These types are used by search_provider_logos::LogoMetadata search_provider_logos::LogoCallbacks viz::InterprocessFramePool::PooledBuffer which are already using explicitly-defaulted ("= default") noexcept move constructors and assignment operators. This is illegal however, as C++ requires the exception specification of an explicitly-defaulted function to be compatible with the exception specification of the implicit declaration (see dcl.fct.def.default in C++11 standard). GCC considers this an error and Clang too, but only if compiling without -fno-exceptions. Bug: 843143, 819294 Change-Id: I24fb8660b3e8c7748cf6b626292ebd6ddd971643 Reviewed-on: https://chromium-review.googlesource.com/1061464 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#560076}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .