Cookie Store: Revamp change observation tests.

//net/cookies/cookie_store_unittest.h contains tests against the
net::CookieStore interface, which is implemented by net::CookieMonster
(in //net/cookies), android_webview::AwCookieStoreWrapper (in
//android_webview/browser/net), and net::CookieStoreIOS and
net::CookieStoreIOSPersistent (in //ios/net/cookies).

Currently, the tests for net::CookieStore::AddCallbackForCookie() are in
//net/cookies/cookie_monster_unittest.cc, so they are not run against
the other net::CookieStore implementations. This is highly undesirable,
as it opens up the possibility for bugs to creep into the other
implementations.

This CL takes the following steps to fix this situation:

1) Move AddCallbackForCookie() tests from cookie_monster_unittest.h to a
   new header file, cooie_store_change_unittest.h.
2) Move AddCallbackForAllChange() tests from cookie_store_unittest.h to
   to the same new new header file, cooie_store_change_unittest.h.
3) Harmonize test styles.
4) Sync the tests for AddCallbackForCookie() with the tests for
   AllCallbackForAllChanges(), so they have the same coverage. This
   results in new tests for both cases.
5) Add more tests covering the change filtering in AddCallbackForCookie().
6) Fix the bugs uncovered by running the tests against
   AwCookieStoreWrapper.

The iOS cookie store implementations will be fixed in a separate CL.

Bug: 729800, 770269
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I10f0a24755a5858d2faa291ef6b855f43a880ec3
Reviewed-on: https://chromium-review.googlesource.com/925694
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538047}
8 files changed