Google Git
Sign in
chromium / chromium / src / f930f101b81d07cd66b0642d10c88edd1a93d2d7
commitf930f101b81d07cd66b0642d10c88edd1a93d2d7[log] [tgz]
authorRune Lillesveen <futhark@chromium.org>Mon Jan 14 12:31:01 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 14 12:31:01 2019
treec4c842cb4ac986d5758611eaa68564245e136360
parent512c89f97ae9b66a598971c361997f9d7a9b2a1e [diff]
Don't compute style in display:none iframes.

display:none iframes do not allow the layout tree to be generated, but
when Squad introduced style recalc for reattachment and
SetNonAttachedStyle(), style computation was no longer blocked by
AttachLayoutTree and the check in LayoutView::CanHaveChildren(). This
lead to style being computed as normal in display:none iframes.

Return null from ParentComputedStyle() when ChildrenCanHaveStyle()
returns false and override ChildrenCanHaveStyle() to return false for
Document when LayoutView::CanHaveChildren() returns false.

Bug: 920599, 914784
Change-Id: Ibb8f4033cb1347c535e0b53d3e2ab9b46aacbd4e
Reviewed-on: https://chromium-review.googlesource.com/c/1405010
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622431}
6 files changed
tree: c4c842cb4ac986d5758611eaa68564245e136360
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .