commit | fabc042a04faa20d56ca4a82425037e7f894d715 | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Wed May 22 21:32:09 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 22 21:32:09 2019 |
tree | 0dac69ba0978712280a8769314623cfd0d8a5a03 | |
parent | cdb318f1f461a292c8b4b20b738433108419c88f [diff] |
Refine check for `self` in magic_check_fn. In a future CL there is a protobuf object on the stack whose __eq__ method freaks out during this comparison. Regardless, the 'is' comparison will always be faster and safer too. R=gbeaty@chromium.org, tandrii@chromium.org Change-Id: I3aacea5fcacbf55d2166a622614c2c725e65872b Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1626477 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email
and user.name
are configured in git config
.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help
and git cl help <cmd>
for more details.