commit fb17d1adfc6538ef3583a28544a025826b25839f
author Victor Costan <pwnall@chromium.org> Fri Feb 23 03:42:26 2018
committer Commit Bot <commit-bot@chromium.org> Fri Feb 23 03:42:26 2018
tree 038ccde805c6910ea8973e79ae20ae92b50bbc73
parent 76bfe086c286a2c54dfa422768d432e1baa08e03

Cookie Store: Clarify that CookieStoreIOS assumes SystemCookiesAllowed.

CookieStoreIOS is one of the two iOS implementations of CookieStore.
Most methods that implement the CookieStore interface have
DCHECK(SystemCookiesAllowed()), whereas a few methods instead handle the
case where SystemCookiesAllowed() returns false.

It is unlikely that the resulting CookieStore implementation is usable
when SystemCookiesAllowed() is false.
* SetCanonicalCookieAsync() calls the system cookie store with no
  workaround
* SetCookieWithOptionsAsync() DCHECKs
* GetCookiesWithOptionsAsync() DCHECKs
* GetCookieListWithOptionsAsync() calls into the CookieMonster
* GetAllCookiesAsync() calls into the CookieMonster
* DeleteCookieAsync() calls into the system cookie store with no
  workaround
* DeleteCanonicalCookieAsync() calls into the system cookie store with
  no workaround

Also, CookieStoreIOS() is currently only instantiated in
CronetEnvironment, which also sets the system cookie store's policy to
NSHTTPCookieAcceptPolicyAlways.

Bug: 729800
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I438b3c9c84f8fbc50a5494b0f9c6ef686b978eca
Reviewed-on: https://chromium-review.googlesource.com/931162
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538689}