Google Git
Sign in
chromium / chromium / src / fb3209a2a966a499243dd844490879f4fb4a6ff8
commitfb3209a2a966a499243dd844490879f4fb4a6ff8[log] [tgz]
authorVasilii Sukhanov <vasilii@chromium.org>Tue Mar 06 18:05:28 2018
committerCommit Bot <commit-bot@chromium.org>Tue Mar 06 18:05:28 2018
treef152139e705d0e764c5aebc42dd9b89582947bed
parenta152858714443c2bfe45acbffd08e853275a0c32 [diff]
Improve password form matching.

Current code is written in a way that a form without action or name doesn't match itself. It's a performance problem because PasswordManager::CreatePendingLoginManagers continuously creates a PasswordFormManager for the same form leading to poor performance.
The code was firstly introduced in https://chromium-review.googlesource.com/c/chromium/src/+/620768. However, motivation for it is unclear after discussing together.

Bug: 801702,597309
Change-Id: Ie2458d8d5340852530675b9f5d7f627132e1f3c6
Reviewed-on: https://chromium-review.googlesource.com/946490
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541145}
7 files changed
tree: f152139e705d0e764c5aebc42dd9b89582947bed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .