commit | fb39a2150be0007063044e3501353e12f89ad67c | [log] [tgz] |
---|---|---|
author | Sergey Ulanov <sergeyu@chromium.org> | Tue Nov 13 03:41:01 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Nov 13 03:41:01 2018 |
tree | 6dff1e74a0407813cfe8037066c8f1fdeebb60c4 | |
parent | bbf03776727dcde72d4dbd5a5e437a5817253602 [diff] |
Improve initialization failure handling in VulkanInstance In debug builds VulkanInstance::Destroy() was trying to call vkDestroyDebugReportCallbackEXT and it would DCHECK after a failure to find that function. That would happen even if Destroy() is called in after a failed attempt to load Vulkan libs. It doesn't make sense to DCHECK in that case. Also now vkDestroyDebugReportCallbackEXT() is called only if debug callbacks were created successfully. Bug: 861853 Change-Id: I03bbdbb1793ddb74f07352f354d0f70ee739a93a Reviewed-on: https://chromium-review.googlesource.com/c/1332263 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607476}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .