Google Git
Sign in
chromium / chromium / src / fb6b132969c51f1954492f21ed99800dd0083ac7
commitfb6b132969c51f1954492f21ed99800dd0083ac7[log] [tgz]
authorJan Krcal <jkrcal@chromium.org>Sat Dec 15 16:33:43 2018
committerCommit Bot <commit-bot@chromium.org>Sat Dec 15 16:33:43 2018
tree49680147fa14674d91029e4f59571baa613ae4fa
parent43ed4581c0e1f963b3accaa71c6f90f2e33e9aa4 [diff]
[AF] Fix reporting to Autofill.Wallet* diff histograms in Directory

This CL fixes how diff metrics are reported from wallet syncable
service. Unlike the USS implementation, it reported diff metrics on
every startup, leading to inconsistencies in number of samples (and also
to inconsistencies in the distribution of the values).

This CL makes sure we do not report on startup
(in MergeDataAndStartSyncing()) but only in real updates
(ProcessSyncChanges()).

Bug: 908905
Change-Id: I813cc9629febdecc3f10929a73345539e12eb842
Reviewed-on: https://chromium-review.googlesource.com/c/1373451
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616981}
6 files changed
tree: 49680147fa14674d91029e4f59571baa613ae4fa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .