Google Git
Sign in
chromium / infra / infra / fb86331614bf13ba01c7a57ad69626e460f8e87a
commitfb86331614bf13ba01c7a57ad69626e460f8e87a[log] [tgz]
authorMiriam Zimmerman <mutexlox@google.com>Mon Dec 21 22:38:37 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Dec 21 22:38:37 2020
tree55c6d37ed372bf105a8e937b8863e868d782770a
parente93d5343d3e9e97c292245652ac30aba89425828 [diff]
phosphorus: Add logging to fetch-crashes command.

https://dashboards.corp.google.com/_dbfdd634_b093_49b5_9c65_49f85cf4b4b0
shows rare cases where fetch-crashes runs for an exceedingly long time.

https://luci-milo.appspot.com/ui/p/chromeos/builders/test_runner/test_runner/b8861152505129815392/steps?succeeded=true&debug=false
is an example of a long execution time --- fetch-crashes indicates that
it's running with a ~16-hour timeout:

[I2020-12-12T03:54:14.940890Z 604554 0 fetch-crashes.go:92] Running with deadline 2020-12-12 19:54:14 +0000 UTC (current time: 2020-12-12 03:54:14.94070739 +0000 UTC)

In this case, fetch-crashes ended up taking 13 hours 47 minutes to
complete, so it did not hit that deadline.

This logging should help us figure out where fetch-crashes is getting
stuck.

In a separate CL, we'll specify a shorter deadline for it.

BUG=chromium:1107005
TEST=ran phosphorus fetch-crashes, verified that logs appeared.

Change-Id: Ia8c50c16cee30ec308f8e47a0419270c00f65a31
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2597820
Reviewed-by: Jared Loucks <jaredloucks@google.com>
Reviewed-by: Prathmesh Prabhu <pprabhu@google.com>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#37185}
1 file changed
tree: 55c6d37ed372bf105a8e937b8863e868d782770a
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.