| commit | fbbf91109648c25132775c8f5e180128780303b9 | [log] [tgz] |
|---|---|---|
| author | jamescook <jamescook@chromium.org> | Tue Jun 14 16:24:49 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Jun 14 16:26:39 2016 |
| tree | ae12a5c5c95f7a84fab89ebbb2f0b68e4ade395d | |
| parent | 536178a5b5ce07bfbd1f01b537e59a7f6d0a4baa [diff] |
Revert of gn BUILD fixes for disabling enable_extensions and use_ash feature flags. (patchset #7 id:120001 of https://codereview.chromium.org/1950003002/ ) Reason for revert: Breaks the chromium.chromiumos gn builder. Repro: gn args out/Default Set to: is_component_build = true use_goma = true target_os = "chromeos" gn gen reports error: ERROR Unresolved dependencies. //:both_gn_and_gyp(//build/toolchain/cros:clang_target) needs //extensions/shell:app_shell(//build/toolchain/cros:clang_target) See https://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20GN%20%28dbg%29&number=22111 Original issue's description: > gn BUILD fixes for disabling enable_extensions and use_ash feature flags. > > BUG= > > Committed: https://crrev.com/2e75c702de464a5cc1cd2272ef720fbe1068c141 > Cr-Commit-Position: refs/heads/master@{#399693} TBR=dgozman@chromium.org,dpranke@google.com,dpranke@chromium.org,mfoltz@chromium.org,ben@chromium.org,asaka@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2064173002 Cr-Commit-Position: refs/heads/master@{#399721}