commit | fbf608630d7590bf0023b8d1aee009ec802e926d | [log] [tgz] |
---|---|---|
author | Dean Michael Berris <dberris@google.com> | Wed Apr 14 11:17:19 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 14 11:17:19 2021 |
tree | 438f45af6b3a660b00f005e1a94866f260331b27 | |
parent | 4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 [diff] |
pinpoint: Fix segfault on missing required input This change increases test coverage and avoids a runtime segfault. R=abennetts@google.com, fancl@chromium.org Bug: chromium:1198823 Change-Id: I00d66b5d490dd7abc3e9ef7169a44954b1c4d699 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2823199 Auto-Submit: Dean Berris <dberris@chromium.org> Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org> Cr-Commit-Position: refs/heads/master@{#40159}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.