commit | fdc875b654b6e7932271024cf59c714ecc428f4c | [log] [tgz] |
---|---|---|
author | Jonathan Ross <jonross@chromium.org> | Tue Jan 16 14:38:23 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 16 14:38:23 2018 |
tree | eb41c46dd9582fd758d2752638151bee77a8090b | |
parent | 2abce4315224305959231c3f263b982dc21372d9 [diff] |
Revert "[LayoutNG] Dump NGPhysicalTextFragment" This reverts commit 76361c1aa7af1296ec50b72d6b853561d6f30c66. Reason for revert: This change has lead to a compilation failure on WinMSCV64 (dbg) due to the added loop in layouttext.cpp having a non-conditional break, leading to there being unreachable code. First failure: https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20%28dbg%29/1970 crbug.com/802222 Original change's description: > [LayoutNG] Dump NGPhysicalTextFragment > > This patch dumps NGPhysicalTextFragment associated with LayoutText > in the same format as InlineTextBox to help reviewing test failures > in LayoutNG. > > LayoutTreeAsText supports RootInlineBox and InlineFlowBox, but they > are not supported for LayoutNG yet. They may be added if they appear > a lot in the text failures, but I have not reviewed them yet. > > Bug: 591099 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I80d6540794cc3630108e02d63a4f749e76e505d1 > Reviewed-on: https://chromium-review.googlesource.com/864962 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529371} TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,ikilpatrick@chromium.org Change-Id: I872fb0b7db858cb751ab092cd3a658c50618304c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/868490 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#529420}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .