Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259903002: DO NOT COMMIT: [Mac] Refactor keyboard shortcut handling so it can be reused in Views. (Closed)

Created:
5 years, 5 months ago by jackhou1
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tfarina, jennb, jianli, Dmitry Titov, dcheng, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT: [Mac] Refactor keyboard shortcut handling so it can be reused in Views. This is a union of the following CLs: Factor out ChromeCommandDispatchDelegate from ChromeEventProcessingWindow. https://codereview.chromium.org/1255783002/ Move UI item validation to CommandDispatchDelegate. https://codereview.chromium.org/1250403002/ [MacViews] Use ChromeCommandDispatchDelegate to handle keyboard shortcuts. https://codereview.chromium.org/1259513002/ BUG= Closing: No longer needed now that other CLs have committed.

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : Sync to new CommandDispatcher design. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+820 lines, -457 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 chunks +0 lines, -208 lines 0 comments Download
A chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm View 1 2 3 1 chunk +319 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window.h View 1 2 3 1 chunk +9 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window.mm View 1 2 3 1 chunk +39 lines, -158 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 2 3 4 chunks +29 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_native_widget_mac.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_native_widget_mac.mm View 1 2 3 4 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mac.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mac.mm View 1 2 3 3 chunks +12 lines, -7 lines 0 comments Download
D chrome/browser/ui/views/frame/native_browser_frame_factory_mac.cc View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
A + chrome/browser/ui/views/frame/native_browser_frame_factory_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D content/public/browser/render_widget_host_view_mac_base.h View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A ui/base/cocoa/command_dispatcher.h View 1 2 3 1 chunk +129 lines, -0 lines 0 comments Download
A ui/base/cocoa/command_dispatcher.mm View 1 2 3 1 chunk +130 lines, -0 lines 0 comments Download
M ui/base/ui_base.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/cocoa/native_widget_mac_nswindow.h View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M ui/views/cocoa/native_widget_mac_nswindow.mm View 1 2 3 5 chunks +55 lines, -0 lines 0 comments Download
M ui/views/controls/webview/unhandled_keyboard_event_handler_mac.mm View 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/examples/webview_example.h View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M ui/views/examples/webview_example.cc View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698