DescriptionPrint stack traces in browser tests when any process crashes, or an assert fires.
The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from processes on all platforms and not just Linux (i.e. to be able to debug the large flakiness that occurred last week). This is disabled for official builds.
Also make release (non-official) builds print the callstack on asserts, just like debug builds. This makes it easier to debug test failures on the CQ (for example, DCHECKs for non-threadsafe usage of pointers).
Add a regression test that both renderer and browser process crashes print the callstack.
BUG=517488, 358267, 521148
NOPRESUBMIT=true
Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975
Cr-Commit-Position: refs/heads/master@{#343240}
Committed: https://crrev.com/79dc59ac7602413181079ecb463873e29a1d7d0a
Cr-Commit-Position: refs/heads/master@{#343626}
Patch Set 1 #
Total comments: 4
Patch Set 2 : fix on bots, still not working on x64 win release #Patch Set 3 : more fixes, works on every configuration now #
Total comments: 2
Patch Set 4 : review comment #Patch Set 5 : fix compile #Patch Set 6 : reupload after revert #Patch Set 7 : patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests #
Total comments: 2
Messages
Total messages: 38 (10 generated)
|