Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1579813002: PoC: Using the toolkit-views fullscreen access bubble on Mac (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PoC: Using the toolkit-views fullscreen access bubble on Mac compile `chrome` on Mac. Flip chrome://flags/#simplified-fullscreen-ui (or or off - they both work) Go, e.g., to YouTube play a video and click the fullscreen icon. BUG=

Patch Set 1 #

Patch Set 2 : Well... it works :o #

Patch Set 3 : Refine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -656 lines) Patch
D chrome/app/nibs/ExclusiveAccessBubble.xib View 1 1 chunk +0 lines, -111 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 2 chunks +40 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 chunks +6 lines, -14 lines 0 comments Download
D chrome/browser/ui/cocoa/exclusive_access_bubble_view.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/ui/cocoa/exclusive_access_bubble_view.mm View 1 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h View 1 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm View 1 1 chunk +0 lines, -352 lines 0 comments Download
M chrome/browser/ui/views/exclusive_access_bubble_views.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/exclusive_access_bubble_views.cc View 1 5 chunks +6 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/exclusive_access_bubble_views_context.h View 1 2 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/chrome_nibs.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
tapted
4 years, 11 months ago (2016-01-12 04:36:11 UTC) #1 
Description was changed from

==========
PoC: Using the toolkit-views fullscreen access bubble on Mac

Initial probing

BUG=
==========

to

==========
PoC: Using the toolkit-views fullscreen access bubble on Mac

compile `chrome` on Mac. Flip chrome://flags/#simplified-fullscreen-ui (or or
off - they both work)

Go, e.g., to YouTube play a video and click the fullscreen icon.

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698