|
|
DescriptionUpdate generated *_pb2.py event_mon files
Summary of changes:
* loaded_size_bytes field was added to RequestStats message in goma_stats.proto
that stores the size of compiler info cache
* BuildCategory enum and category field was added to BuildEvent message to store
category build property
* FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE
values were added to FailType enum in CQEvent message
* config_revision field was added to CQEvent message
BUG=562109, 579589
Committed: https://chromium.googlesource.com/infra/infra/+/83dfe87b00f8eadc467ead5766e256cfc5548db0
Patch Set 1 #Patch Set 2 : Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py #Patch Set 3 : rebase chrome_infra_log_pb2.py #
Messages
Total messages: 25 (13 generated)
The CQ bit was checked by tikuta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py * the field store the size of compiler info cache BUG= ========== to ========== Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py * the field stores the size of compiler info cache BUG= ==========
Description was changed from ========== Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py * the field stores the size of compiler info cache BUG= ========== to ========== Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py * the field stores the size of compiler info cache BUG= ==========
tikuta@chromium.org changed reviewers: + sergiyb@chromium.org, shinyak@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org
lgtm provided changes in proto are already in production, check latest deployed CL here: https://cl-status.corp.google.com/#/summary/clearcut_server and make sure that internal CL number is smaller than number in prod.
On 2016/07/11 08:19:04, Sergiy Byelozyorov wrote: > lgtm provided changes in proto are already in production, check latest deployed > CL here: https://cl-status.corp.google.com/#/summary/clearcut_server and make > sure that internal CL number is smaller than number in prod. I've just checked myself, it's still not in prod. Although this CL will probably not break anything, it is still advisable to wait until all involved changes are in prod.
On 2016/07/11 10:07:25, Sergiy Byelozyorov wrote: > On 2016/07/11 08:19:04, Sergiy Byelozyorov wrote: > > lgtm provided changes in proto are already in production, check latest > deployed > > CL here: https://cl-status.corp.google.com/#/summary/clearcut_server and make > > sure that internal CL number is smaller than number in prod. > > I've just checked myself, it's still not in prod. Although this CL will probably > not break anything, it is still advisable to wait until all involved changes are > in prod. P.S. Also after this lands, please make sure to push deployed branch past this commit and notify everyone about it by sending an email to chrome-infra@ and current troopers.
Description was changed from ========== Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py * the field stores the size of compiler info cache BUG= ========== to ========== Update generated *_pb2.py event_mon files Summary of changes: * loaded_size_bytes field was added to RequestStats message in goma_stats.proto that stores the size of compiler info cache * BuildCategory enum and category field was added to BuildEvent message to store category build property * FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE values were added to FailType enum in CQEvent message * config_revision field was added to CQEvent message BUG=562109, 579589 ==========
Description was changed from ========== Update generated *_pb2.py event_mon files Summary of changes: * loaded_size_bytes field was added to RequestStats message in goma_stats.proto that stores the size of compiler info cache * BuildCategory enum and category field was added to BuildEvent message to store category build property * FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE values were added to FailType enum in CQEvent message * config_revision field was added to CQEvent message BUG=562109, 579589 ========== to ========== Update generated *_pb2.py event_mon files Summary of changes: * loaded_size_bytes field was added to RequestStats message in goma_stats.proto that stores the size of compiler info cache * BuildCategory enum and category field was added to BuildEvent message to store category build property * FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE values were added to FailType enum in CQEvent message * config_revision field was added to CQEvent message BUG=562109, 579589 ==========
On 2016/07/11 10:09:10, Sergiy Byelozyorov wrote: > On 2016/07/11 10:07:25, Sergiy Byelozyorov wrote: > > On 2016/07/11 08:19:04, Sergiy Byelozyorov wrote: > > > lgtm provided changes in proto are already in production, check latest > > deployed > > > CL here: https://cl-status.corp.google.com/#/summary/clearcut_server and > make > > > sure that internal CL number is smaller than number in prod. > > > > I've just checked myself, it's still not in prod. Although this CL will > probably > > not break anything, it is still advisable to wait until all involved changes > are > > in prod. > > P.S. Also after this lands, please make sure to push deployed branch past this > commit and notify everyone about it by sending an email to chrome-infra@ and > current troopers. P.P.S. I've updated description to include summary of all changes to the proto file
tandrii@chromium.org changed reviewers: + tandrii@chromium.org
LGTM (and thanks for updating descr, sergiyb@)
lgtm
lgtm
lgtm
Thank you for review. Thank you sergiyb@ updating description. I confirm that my change landed to clearcut server. Let me commit this CL.
The CQ bit was checked by tikuta@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yyanagisawa@chromium.org, sergiyb@chromium.org, tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/2138623002/#ps40001 (title: "rebase chrome_infra_log_pb2.py")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update generated *_pb2.py event_mon files Summary of changes: * loaded_size_bytes field was added to RequestStats message in goma_stats.proto that stores the size of compiler info cache * BuildCategory enum and category field was added to BuildEvent message to store category build property * FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE values were added to FailType enum in CQEvent message * config_revision field was added to CQEvent message BUG=562109, 579589 ========== to ========== Update generated *_pb2.py event_mon files Summary of changes: * loaded_size_bytes field was added to RequestStats message in goma_stats.proto that stores the size of compiler info cache * BuildCategory enum and category field was added to BuildEvent message to store category build property * FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE values were added to FailType enum in CQEvent message * config_revision field was added to CQEvent message BUG=562109, 579589 Committed: https://chromium.googlesource.com/infra/infra/+/83dfe87b00f8eadc467ead5766e25... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/83dfe87b00f8eadc467ead5766e25... |