Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2638423005: Make FrameSelection to utilize SynchronousMutationObserver (Closed)

Created:
3 years, 11 months ago by yosin_UTC9
Modified:
3 years, 11 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FrameSelection to utilize SynchronousMutationObserver This patch makes |FrameSelection| to utilize |SynchronousMutationObserver| to simplify DOM mutation observing by removing call from |Document| for improving code health and a preparation of [1]. [1] http://crrev.com/2637013002: WIP Make Document to hold non- canonicalized positions BUG=682878 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2638423005 Cr-Commit-Position: refs/heads/master@{#445043} Committed: https://chromium.googlesource.com/chromium/src/+/cafd47a29528e260f26587c8eab0db161855e851

Patch Set 1 : 2017-01-20T16:41:12 #

Patch Set 2 : 2017-01-20T17:21:21 #

Patch Set 3 : 2017-01-20T19:16:11 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 5 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 4 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 5 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
yosin_UTC9
PTAL
3 years, 11 months ago (2017-01-20 09:25:14 UTC) #13
tkent
lgtm
3 years, 11 months ago (2017-01-20 09:27:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638423005/40001
3 years, 11 months ago (2017-01-20 09:32:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/346298)
3 years, 11 months ago (2017-01-20 09:37:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638423005/60001
3 years, 11 months ago (2017-01-20 10:22:05 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 11:59:51 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cafd47a29528e260f26587c8eab0...

Powered by Google App Engine
This is Rietveld 408576698