|
Update avatar button to MD
Summary of changes made [ see screenshots in https://bugs.chromium.org/p/chromium/issues/detail?id=635699&desc=2#c36 ]:
1) Show new MD button only on Windows 10 and only if not using a theme
2) Make MD button "cozy" (22px) when tabstrip is full and not maximised and text direction is LTR (RTL can be tested with --force-ui-direction=rtl)
3) Make "tall" (non-cozy) MD button the same height as caption bar buttons - it's not pixel-perfect (see issue 668278)
4) Change icon and highlighting for MD button (see screenshots attached)
5) Show "ink drop" animation when MD button is clicked, like for bookmarks bar and other menu buttons
6) Make menu appear on press, not on release (for all platforms, not just Windows 10)
7) Keep button in "pressed" state while the profile menu is shown (for all platforms)
BUG= 635699
Total comments: 24
Total comments: 2
Total comments: 22
Total comments: 15
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+527 lines, -237 lines) |
Patch |
|
M |
chrome/browser/ui/views/frame/avatar_button_manager.h
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/avatar_button_manager.cc
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+36 lines, -16 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame.h
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_non_client_frame_view.h
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
|
View
|
1
2
3
4
5
6
7
|
5 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/glass_browser_frame_view.h
|
View
|
1
2
3
4
5
6
7
|
6 chunks |
+19 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/glass_browser_frame_view.cc
|
View
|
1
2
3
4
5
6
7
|
13 chunks |
+79 lines, -24 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/opaque_browser_frame_view.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
|
View
|
1
2
3
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/profiles/avatar_button_delegate.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/profiles/new_avatar_button.h
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+72 lines, -21 lines |
11 comments
|
Download
|
|
M |
chrome/browser/ui/views/profiles/new_avatar_button.cc
|
View
|
1
2
3
4
5
6
7
|
6 chunks |
+211 lines, -110 lines |
2 comments
|
Download
|
|
M |
chrome/browser/ui/views/profiles/profile_chooser_view.h
|
View
|
|
5 chunks |
+13 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/profiles/profile_chooser_view.cc
|
View
|
|
5 chunks |
+22 lines, -5 lines |
2 comments
|
Download
|
|
M |
chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
ui/display/win/screen_win.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/display/win/screen_win.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+27 lines, -23 lines |
0 comments
|
Download
|
Depends on Patchset:
Total messages: 40 (28 generated)
|