Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 616253002: Extract NativeAppWindow from src/extensions

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, sadrul, nkostylev+watch_chromium.org, estade+watch_chromium.org, benquan, tfarina, dyu1, dcheng, mkwst+moarreviews-ipc_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Dane Wallinga
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Extract NativeAppWindow from src/extensions BUG=

Patch Set 1 #

Patch Set 2 : git-cl-format #

Patch Set 3 : Back off some changes for clearer review #

Patch Set 4 : might fix athena. similarity=33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+845 lines, -842 lines) Patch
M apps/app_lifetime_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/apps.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M apps/ui/views/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M apps/ui/views/app_window_frame_view.h View 3 chunks +6 lines, -6 lines 0 comments Download
M apps/ui/views/app_window_frame_view.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M athena/athena.gyp View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/athena_app_window_client_base.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M athena/extensions/athena_app_window_client_base.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_window_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_window_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_apps_client_views.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_apps_client_views_win.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.h View 1 2 4 chunks +18 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 16 chunks +34 lines, -30 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 2 6 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/components.gyp View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M components/native_app_window.gypi View 1 2 2 chunks +44 lines, -6 lines 0 comments Download
M components/native_app_window/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
A components/native_app_window/app_window_create_params.h View 1 chunk +128 lines, -0 lines 0 comments Download
A components/native_app_window/app_window_create_params.cc View 1 2 1 chunk +141 lines, -0 lines 0 comments Download
A components/native_app_window/draggable_region.h View 1 chunk +31 lines, -0 lines 0 comments Download
A components/native_app_window/draggable_region.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + components/native_app_window/native_app_window.h View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
A components/native_app_window/native_app_window_delegate.h View 1 chunk +48 lines, -0 lines 0 comments Download
A components/native_app_window/native_app_window_export.h View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
M components/native_app_window/native_app_window_views.h View 1 7 chunks +20 lines, -21 lines 0 comments Download
M components/native_app_window/native_app_window_views.cc View 1 11 chunks +20 lines, -19 lines 0 comments Download
A + components/native_app_window/size_constraints.h View 2 chunks +7 lines, -6 lines 0 comments Download
A + components/native_app_window/size_constraints.cc View 1 2 chunks +15 lines, -13 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.h View 2 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 11 chunks +15 lines, -15 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 1 2 3 12 chunks +34 lines, -141 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 2 17 chunks +92 lines, -210 lines 0 comments Download
M extensions/browser/app_window/app_window_client.h View 2 chunks +8 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.h View 3 chunks +4 lines, -4 lines 0 comments Download
D extensions/browser/app_window/native_app_window.h View 1 2 1 chunk +4 lines, -92 lines 0 comments Download
D extensions/browser/app_window/size_constraints.h View 1 chunk +0 lines, -57 lines 0 comments Download
D extensions/browser/app_window/size_constraints.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M extensions/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D extensions/common/draggable_region.h View 1 chunk +0 lines, -21 lines 0 comments Download
D extensions/common/draggable_region.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M extensions/common/extension_messages.h View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 chunks +1 line, -4 lines 0 comments Download
M extensions/renderer/extension_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_app_window_client.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
tapted
Patchset #3 (id:40001) has been deleted
6 years, 2 months ago (2014-10-01 06:20:38 UTC) #1
tapted
6 years, 2 months ago (2014-10-01 08:29:44 UTC) #2 
Patchset #4 (id:80001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698