Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 914573003: Revert "We need to account for culled inline parents of the hit-tested..." (Closed)

Created:
5 years, 10 months ago by Miyoung Shin(g)
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "We need to account for culled inline parents of the hit-tested..." Reason for revert: Flickering is observed on text selection when hitting culled inline, because culled inline doesn't get the right position from RenderInline::positionForPoint for the selection. First I revert the origin patch not to hit culled inline, then I will fix this issue. > We need to account for culled inline parents of the hit-tested nodes.(Reland) > > There are two kind of problem. > One is that we get the wrong hit-test result from culled inlines > because we try to overrun checking them until top of parent. > The other is that mouse events aren't fired when there is the > element culled inline like label element that doesn't has any > background color or border or self-layer. > > This patch makes hit-test include not only area-based hit-tests > but also point-based ones at the place handling culled inline. > > More information: https://docs.google.com/presentation/d/1KlT_FQxCTGeH-lPWjzXnPdZ3Bb1p7GL-IwoP-SfGvEo/edit#slide=id.g535467cad_40 > > BUG=312199, 435483 > R=rbyers@chromium.org, pdr@chromium.org, leviw@chromium.org > TEST=fast/events/hit-test-culled_inline.html > =fast/dom/nodesFromRect/nodesFromRect-culled-inlines-between-silblings.html BUG=455672 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189949

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 12 (5 generated)
Miyoung Shin(g)
@pdr, PTAL
5 years, 10 months ago (2015-02-10 08:09:33 UTC) #2
pdr.
lgtm
5 years, 10 months ago (2015-02-10 21:42:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914573003/1
5 years, 10 months ago (2015-02-10 21:43:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/25751)
5 years, 10 months ago (2015-02-10 21:51:12 UTC) #7
pdr.
lgtm
5 years, 10 months ago (2015-02-11 04:16:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914573003/20001
5 years, 10 months ago (2015-02-11 04:17:10 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 05:31:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189949

Powered by Google App Engine
This is Rietveld 408576698