Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2040963004: Reland: ImageCapture: move mojom from WebKit/public to media/ (Closed)

Created:
4 years, 6 months ago by mcasas
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, feature-media-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, blink-reviews, darin (slow to review), ben+mojo_chromium.org, blink-reviews-api_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: ImageCapture: move mojom from WebKit/public to media/ Reverted after its own LayoutTests timed out in WebKit Win7 bot. This is due to media/mojo/interfaces not being in the generated bindings path, and that's being addressed in https://codereview.chromium.org/2045573002/. Original landed as https://crrev.com/2027023002 Original description --------------------------------------------------- ImageCapture: move mojom from WebKit/public to media/ This CL moves image_capture.mojom from {third_party/WebKit/public/platform/modules => media/mojo/interfaces} so the generated data types (e.g. PhotoCapabilities{Ptr}) can be used from both Blink and media/capture locations. Also capture.gypi is trivially relocated to capture/ folder. Note that gyp files are -yay!- close to being finally removed. BUG=518807 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel TBR=rockot@chromium.org, avi@chromium.org, dcheng@chromium.org, haraken@chromium.org, xhwang@chromium.org (no code changes). Committed: https://crrev.com/afcfc05a1d1f4b2f5c7139206e59ece159241f2b Cr-Commit-Position: refs/heads/master@{#398117}

Patch Set 1 : https://crrev.com/2027023002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -166 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/image_capture_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/image_capture_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
D media/capture.gypi View 1 chunk +0 lines, -106 lines 0 comments Download
A + media/capture/capture.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M media/media.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + media/mojo/interfaces/image_capture.mojom View 2 chunks +9 lines, -1 line 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/imagecapture/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/modules/imagecapture/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/public/platform/modules/imagecapture/image_capture.mojom View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040963004/1
4 years, 6 months ago (2016-06-06 19:23:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 20:48:00 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:50:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afcfc05a1d1f4b2f5c7139206e59ece159241f2b
Cr-Commit-Position: refs/heads/master@{#398117}

Powered by Google App Engine
This is Rietveld 408576698