Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2447013002: cc::VideoResourceUpdater: NOTREACHED;return; replaced by DCHECK. (Closed)

Created:
4 years, 1 month ago by aleksandar.stojiljkovic
Modified:
4 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, posciak+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc::VideoResourceUpdater: NOTREACHED;return; replaced by DCHECK. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/5d5534ba7763185e515dbd98560165031a9cdef8 Cr-Commit-Position: refs/heads/master@{#427474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M cc/resources/video_resource_updater.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
aleksandar.stojiljkovic
As suggested in https://crrev.com/2428263004/#msg27, replacing NOTREACHED; return; with DCHECK.
4 years, 1 month ago (2016-10-25 09:57:03 UTC) #3
danakj
LGTM
4 years, 1 month ago (2016-10-25 20:22:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447013002/1
4 years, 1 month ago (2016-10-25 20:22:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 21:18:11 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:20:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d5534ba7763185e515dbd98560165031a9cdef8
Cr-Commit-Position: refs/heads/master@{#427474}

Powered by Google App Engine
This is Rietveld 408576698