Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3) (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years ago
Reviewers:
kinuko, Adam Rice, sky, tzik
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, loading-reviews+fetch_chromium.org, Yoav Weiss, extensions-reviews_chromium.org, jam, tyoshino+watch_chromium.org, loading-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, Paweł Hajdan Jr., blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch, Nate Chapin, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send encoded_body_length to renderer when response completed (2/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit# This CL - removes encoded_body_length() from RequestPeer::ReceivedData. - removes encodedBodyLength parameter from WebURLLoaderClient::didReceiveData, - adds totalEncodedBodyLength parameter to WebURLLoaderClient::didFinishLoading, - adds totalEncodedBodyLength parameter to WebURLLoaderClient::didFail. BUG=666216 Committed: https://crrev.com/b82cdb024079a83c15b4c2c02ea28700ef6797cf Cr-Commit-Position: refs/heads/master@{#434654}

Patch Set 1 : fix #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -235 lines) Patch
M chrome/renderer/extensions/extension_localization_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 8 chunks +24 lines, -23 lines 0 comments Download
M chrome/renderer/security_filter_peer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/security_filter_peer.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M content/child/ftp_directory_listing_response_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/child/shared_memory_received_data_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/shared_memory_received_data_factory.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M content/child/shared_memory_received_data_factory_unittest.cc View 5 chunks +19 lines, -20 lines 0 comments Download
M content/child/url_response_body_consumer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/web_url_loader_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 10 chunks +19 lines, -15 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 1 8 chunks +15 lines, -16 lines 0 comments Download
M content/public/child/fixed_received_data.h View 1 chunk +2 lines, -9 lines 0 comments Download
M content/public/child/fixed_received_data.cc View 2 chunks +5 lines, -16 lines 0 comments Download
M content/public/child/request_peer.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 11 chunks +23 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 5 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLLoaderTestDelegate.cpp View 1 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp View 1 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimRequest.cpp View 1 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoader.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderClient.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderTestDelegate.h View 1 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 36 (27 generated)
yhirano
4 years, 1 month ago (2016-11-18 09:21:51 UTC) #13
Adam Rice
lgtm
4 years, 1 month ago (2016-11-21 09:05:50 UTC) #18
kinuko
lgtm
4 years, 1 month ago (2016-11-21 12:51:25 UTC) #20
tzik
lgtm
4 years, 1 month ago (2016-11-22 05:54:09 UTC) #21
yhirano
+sky@ for chrome/ changes.
4 years, 1 month ago (2016-11-22 07:37:13 UTC) #23
sky
LGTM
4 years, 1 month ago (2016-11-22 20:07:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510333002/60001
4 years ago (2016-11-28 14:13:38 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-11-28 14:18:10 UTC) #34
commit-bot: I haz the power
4 years ago (2016-11-28 14:20:16 UTC) #36
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b82cdb024079a83c15b4c2c02ea28700ef6797cf
Cr-Commit-Position: refs/heads/master@{#434654}

Powered by Google App Engine
This is Rietveld 408576698