Send encoded_body_length to renderer when response completed (1/3)

Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/efb9d78772531d0de6900f1f1a213f5cb8b5ebab
Cr-Commit-Position: refs/heads/master@{#434624}

[yhirano, 2016-11-18 04:11:25]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 04:12:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 05:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 05:12:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yhirano, 2016-11-18 06:09:41]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 06:09:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-18 06:47:33]

Description was changed from

==========
Dispatch encoded_body_size at the completion timing

BUG=666216
==========

to

==========
Dispatch encoded_body_size at the completion timing (1/3)

BUG=666216
==========

[commit-bot: I haz the power, 2016-11-18 07:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:34:53]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-18 08:07:06]

Description was changed from

==========
Dispatch encoded_body_size at the completion timing (1/3)

BUG=666216
==========

to

==========
Dispatch encoded_body_size at the completion timing (1/3)

Currently, "encoded_data_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

This CL add "encoded_data_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[yhirano, 2016-11-18 08:07:06]

yhirano@chromium.org changed reviewers:
+ rdsmith@chromium.org, ricea@chromium.org, tzik@chromium.org

[yhirano, 2016-11-18 08:07:35]

Description was changed from

==========
Dispatch encoded_body_size at the completion timing (1/3)

Currently, "encoded_data_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

This CL add "encoded_data_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Dispatch encoded_body_length at the completion timing (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

This CL add "encoded_data_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[yhirano, 2016-11-18 08:07:52]

Description was changed from

==========
Dispatch encoded_body_length at the completion timing (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

This CL add "encoded_data_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Dispatch encoded_body_length at the completion timing (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[yhirano, 2016-11-18 09:21:24]

+rdsmith@ for net/test and content/browser/loader.
+ricea@, tzik@ for the overall change.

[Randy Smith (Not in Mondays), 2016-11-18 20:57:45]

A couple of questions:
* Could you give pointers to the other CLs in this series so that I can
understand the context?
* Is there a reason you didn't initialize the new field at all creations of
ResourceRequestCompletionStatus?  (I'm thinking specifically of the one in
resource_dispatcher_host_impl.cc: AbortRequestBeforeItStarts(), but codesearch
surfaces some others).
* What test failure required updated URLRequestFailedJob?

[yhirano, 2016-11-21 02:31:40]

Description was changed from

==========
Dispatch encoded_body_length at the completion timing (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Dispatch encoded_body_length at the completion timing (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[yhirano, 2016-11-21 03:40:29]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 03:40:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-21 03:53:18]

> * Could you give pointers to the other CLs in this series so that I can
> understand the context?
Done.

> * Is there a reason you didn't initialize the new field at all creations of
> ResourceRequestCompletionStatus?  (I'm thinking specifically of the one in
> resource_dispatcher_host_impl.cc: AbortRequestBeforeItStarts(), but codesearch
> surfaces some others).
Excluding test related ones, ResourceDispatcherHostImpl and
URLResponseBodyConsumer instantiate the class. For the former case, we should
set 0 as the resource loading is cancelled before starting. Though 0 is the
default value, I added the statement for consistency at PS2. For the latter
case, we don't have to initialize it to a specific value because it will be set
to a value coming from the browser process.

> * What test failure required updated URLRequestFailedJob?
I want to check that different values are set to encoded_data_length and
encoded_body_length in MojoAsyncResourceHandler. URLRequestMockHTTPJob used in
url_laoder_factory_impl_unittest.cc inherits URLRequestFileJob, so the same
value will be set. With the URLRequestFailedJob change, we can distinguish them.
URLLoaderFactoryImplTest::GetFailedResponse2 is the test case checking that.

[Adam Rice, 2016-11-21 04:26:48]

lgtm with nits.

Bonus nitpick: The title of the CL could be clearer. How about "Send
encoded_body_length to renderer when response completed"?

https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/...
File content/browser/loader/async_resource_handler.cc (right):

https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/...
content/browser/loader/async_resource_handler.cc:518: info->filter()->Send(
Indentation looks wrong.

https://codereview.chromium.org/2514713002/diff/40001/content/common/resource...
File content/common/resource_request_completion_status.h (right):

https://codereview.chromium.org/2514713002/diff/40001/content/common/resource...
content/common/resource_request_completion_status.h:37: // Total amount of the
response body in the encoded format.
This is a little hard to understand. I suggest just using the first sentence
from the description of URLRequest::GetRawBodyBytes(), ie.

"The size of the response body before removing any content encodings."

Maybe you could adapt it to the words used in this part of the code, ie.

"The length of the body before removing any content encodings."

Since content encodings are always used for compression in practice, I think

"The length of the body before decompression."

is okay, although it is a little bit imprecise.

[commit-bot: I haz the power, 2016-11-21 04:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 04:39:49]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-21 06:29:06]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:29:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-21 06:38:41]

Description was changed from

==========
Dispatch encoded_body_length at the completion timing (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[yhirano, 2016-11-21 06:40:27]

> Bonus nitpick: The title of the CL could be clearer. How about "Send
> encoded_body_length to renderer when response completed"?

Thanks, done.

https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/...
File content/browser/loader/async_resource_handler.cc (right):

https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/...
content/browser/loader/async_resource_handler.cc:518: info->filter()->Send(
On 2016/11/21 04:26:48, Adam Rice wrote:
> Indentation looks wrong.

Done.

https://codereview.chromium.org/2514713002/diff/40001/content/common/resource...
File content/common/resource_request_completion_status.h (right):

https://codereview.chromium.org/2514713002/diff/40001/content/common/resource...
content/common/resource_request_completion_status.h:37: // Total amount of the
response body in the encoded format.
On 2016/11/21 04:26:48, Adam Rice wrote:
> This is a little hard to understand. I suggest just using the first sentence
> from the description of URLRequest::GetRawBodyBytes(), ie.
> 
> "The size of the response body before removing any content encodings."
> 
> Maybe you could adapt it to the words used in this part of the code, ie.
> 
> "The length of the body before removing any content encodings."
> 
> Since content encodings are always used for compression in practice, I think
> 
> "The length of the body before decompression."
> 
> is okay, although it is a little bit imprecise.

Done.

[commit-bot: I haz the power, 2016-11-21 07:37:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 07:37:24]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-11-21 09:49:18]

Could you link directly to the design doc from the description? It would
save people from having to follow the bug link to find it.

[yhirano, 2016-11-21 12:03:18]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[yhirano, 2016-11-21 12:04:31]

On 2016/11/21 09:49:18, Adam Rice wrote:
> Could you link directly to the design doc from the description? It would
> save people from having to follow the bug link to find it.

Done.

[kinuko, 2016-11-21 12:46:52]

lgtm (once Randy's happy)

[tzik, 2016-11-22 05:38:16]

lgtm

[yhirano, 2016-11-22 06:05:02]

yhirano@chromium.org changed reviewers:
+ tsepez@chromium.org

[yhirano, 2016-11-22 06:05:52]

+tsepez@ for content/common/resource_messages.h

[yhirano, 2016-11-22 06:06:20]

(I'm still waiting for rdsmith@'s feedback, in case it's not clear.)

[Randy Smith (Not in Mondays), 2016-11-22 16:02:13]

On 2016/11/21 03:53:18, yhirano OOO till 11-28 wrote:
> > * Could you give pointers to the other CLs in this series so that I can
> > understand the context?
> Done.
> 
> > * Is there a reason you didn't initialize the new field at all creations of
> > ResourceRequestCompletionStatus?  (I'm thinking specifically of the one in
> > resource_dispatcher_host_impl.cc: AbortRequestBeforeItStarts(), but
codesearch
> > surfaces some others).
> Excluding test related ones, ResourceDispatcherHostImpl and
> URLResponseBodyConsumer instantiate the class. For the former case, we should
> set 0 as the resource loading is cancelled before starting. Though 0 is the
> default value, I added the statement for consistency at PS2. For the latter
> case, we don't have to initialize it to a specific value because it will be
set
> to a value coming from the browser process.

Ah, gotcha.  I had missed that that class did it's initialization in the
declaration; I'm not used to that idiom yet.  Still, I'm glad to have the
initializations you put in for consistencies sake.

LGTM.

> 
> > * What test failure required updated URLRequestFailedJob?
> I want to check that different values are set to encoded_data_length and
> encoded_body_length in MojoAsyncResourceHandler. URLRequestMockHTTPJob used in
> url_laoder_factory_impl_unittest.cc inherits URLRequestFileJob, so the same
> value will be set. With the URLRequestFailedJob change, we can distinguish
them.
> URLLoaderFactoryImplTest::GetFailedResponse2 is the test case checking that.

[Tom Sepez, 2016-11-22 17:06:30]

RS LGTM, browser to renderer message.

[yhirano, 2016-11-22 21:39:51]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-22 21:39:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ricea@chromium.org
Link to the patchset: https://codereview.chromium.org/2514713002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-11-22 21:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:59:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479850791235850,
"parent_rev": "575b456bffe66171c8a04e3f91930cf112d9bcb0", "commit_rev":
"9fcd59b5bcc02e50fb889289685465e6e4fc5c7e"}

[commit-bot: I haz the power, 2016-11-22 23:59:38]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

[commit-bot: I haz the power, 2016-11-22 23:59:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-23 00:03:12]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}
==========

[commit-bot: I haz the power, 2016-11-23 00:03:14]

Patchset 4 (id:??) landed as
https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

[Maria, 2016-11-23 01:04:22]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2515383004/ by mariakhomenko@chromium.org.

The reason for reverting is: I believe this change broke cronet tests:

https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Mar....

[pauljensen, 2016-11-23 01:56:00]

Feel free to reland this change once you incorporate
https://codereview.chromium.org/2526653002/, I'll review it once you've
incorporated it.

[yhirano, 2016-11-28 02:06:31]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}
==========

[yhirano, 2016-11-28 02:06:42]

reopening...

[yhirano, 2016-11-28 02:06:59]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[yhirano, 2016-11-28 02:07:19]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 02:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 03:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 03:02:50]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[yhirano, 2016-11-28 06:11:49]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 06:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-28 06:48:28]

Thanks, pauljensen@. Can you take a look at PS5?

[commit-bot: I haz the power, 2016-11-28 09:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 09:18:09]

Dry run: This issue passed the CQ dry run.

[pauljensen, 2016-11-28 09:20:10]

components/cronet/ lgtm

[yhirano, 2016-11-28 09:25:02]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-28 09:25:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org,
ricea@chromium.org, rdsmith@chromium.org, kinuko@chromium.org,
tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2514713002/#ps80001
(title: "merge https://codereview.chromium.org/2526653002/")

[commit-bot: I haz the power, 2016-11-28 09:25:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 09:29:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480325102795490,
"parent_rev": "efb7ade8ca82e697aed28bd5420ab8a6c3a72574", "commit_rev":
"ead681bca86f82d27dac3f079d0df29343bc7c53"}

[commit-bot: I haz the power, 2016-11-28 09:29:31]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2016-11-28 09:29:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-28 09:30:53]

Description was changed from

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Send encoded_body_length to renderer when response completed (1/3)

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc:
https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG...

This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.

BUG=666216

Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/efb9d78772531d0de6900f1f1a213f5cb8b5ebab
Cr-Commit-Position: refs/heads/master@{#434624}
==========

[commit-bot: I haz the power, 2016-11-28 09:30:55]

Patchset 5 (id:??) landed as
https://crrev.com/efb9d78772531d0de6900f1f1a213f5cb8b5ebab
Cr-Commit-Position: refs/heads/master@{#434624}