|
|
Created:
4 years, 1 month ago by yhirano Modified:
4 years ago CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), mmenke Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSend encoded_body_length to renderer when response completed (1/3)
Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.
- 1/3: https://codereview.chromium.org/2514713002/
- 2/3: https://codereview.chromium.org/2510333002/
- 3/3: https://codereview.chromium.org/2506363005/
Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#
This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus.
This CL doesn't change the behavior.
BUG=666216
Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433
Cr-Commit-Position: refs/heads/master@{#434032}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Committed: https://crrev.com/efb9d78772531d0de6900f1f1a213f5cb8b5ebab
Cr-Commit-Position: refs/heads/master@{#434624}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix #
Total comments: 4
Patch Set 4 : fix #Patch Set 5 : merge https://codereview.chromium.org/2526653002/ #Dependent Patchsets: Messages
Total messages: 69 (45 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Dispatch encoded_body_size at the completion timing BUG=666216 ========== to ========== Dispatch encoded_body_size at the completion timing (1/3) BUG=666216 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Dispatch encoded_body_size at the completion timing (1/3) BUG=666216 ========== to ========== Dispatch encoded_body_size at the completion timing (1/3) Currently, "encoded_data_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL add "encoded_data_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
yhirano@chromium.org changed reviewers: + rdsmith@chromium.org, ricea@chromium.org, tzik@chromium.org
Description was changed from ========== Dispatch encoded_body_size at the completion timing (1/3) Currently, "encoded_data_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL add "encoded_data_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Dispatch encoded_body_length at the completion timing (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL add "encoded_data_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
Description was changed from ========== Dispatch encoded_body_length at the completion timing (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL add "encoded_data_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Dispatch encoded_body_length at the completion timing (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
+rdsmith@ for net/test and content/browser/loader. +ricea@, tzik@ for the overall change.
A couple of questions: * Could you give pointers to the other CLs in this series so that I can understand the context? * Is there a reason you didn't initialize the new field at all creations of ResourceRequestCompletionStatus? (I'm thinking specifically of the one in resource_dispatcher_host_impl.cc: AbortRequestBeforeItStarts(), but codesearch surfaces some others). * What test failure required updated URLRequestFailedJob?
Description was changed from ========== Dispatch encoded_body_length at the completion timing (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Dispatch encoded_body_length at the completion timing (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> * Could you give pointers to the other CLs in this series so that I can > understand the context? Done. > * Is there a reason you didn't initialize the new field at all creations of > ResourceRequestCompletionStatus? (I'm thinking specifically of the one in > resource_dispatcher_host_impl.cc: AbortRequestBeforeItStarts(), but codesearch > surfaces some others). Excluding test related ones, ResourceDispatcherHostImpl and URLResponseBodyConsumer instantiate the class. For the former case, we should set 0 as the resource loading is cancelled before starting. Though 0 is the default value, I added the statement for consistency at PS2. For the latter case, we don't have to initialize it to a specific value because it will be set to a value coming from the browser process. > * What test failure required updated URLRequestFailedJob? I want to check that different values are set to encoded_data_length and encoded_body_length in MojoAsyncResourceHandler. URLRequestMockHTTPJob used in url_laoder_factory_impl_unittest.cc inherits URLRequestFileJob, so the same value will be set. With the URLRequestFailedJob change, we can distinguish them. URLLoaderFactoryImplTest::GetFailedResponse2 is the test case checking that.
lgtm with nits. Bonus nitpick: The title of the CL could be clearer. How about "Send encoded_body_length to renderer when response completed"? https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/... File content/browser/loader/async_resource_handler.cc (right): https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/... content/browser/loader/async_resource_handler.cc:518: info->filter()->Send( Indentation looks wrong. https://codereview.chromium.org/2514713002/diff/40001/content/common/resource... File content/common/resource_request_completion_status.h (right): https://codereview.chromium.org/2514713002/diff/40001/content/common/resource... content/common/resource_request_completion_status.h:37: // Total amount of the response body in the encoded format. This is a little hard to understand. I suggest just using the first sentence from the description of URLRequest::GetRawBodyBytes(), ie. "The size of the response body before removing any content encodings." Maybe you could adapt it to the words used in this part of the code, ie. "The length of the body before removing any content encodings." Since content encodings are always used for compression in practice, I think "The length of the body before decompression." is okay, although it is a little bit imprecise.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Dispatch encoded_body_length at the completion timing (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
> Bonus nitpick: The title of the CL could be clearer. How about "Send > encoded_body_length to renderer when response completed"? Thanks, done. https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/... File content/browser/loader/async_resource_handler.cc (right): https://codereview.chromium.org/2514713002/diff/40001/content/browser/loader/... content/browser/loader/async_resource_handler.cc:518: info->filter()->Send( On 2016/11/21 04:26:48, Adam Rice wrote: > Indentation looks wrong. Done. https://codereview.chromium.org/2514713002/diff/40001/content/common/resource... File content/common/resource_request_completion_status.h (right): https://codereview.chromium.org/2514713002/diff/40001/content/common/resource... content/common/resource_request_completion_status.h:37: // Total amount of the response body in the encoded format. On 2016/11/21 04:26:48, Adam Rice wrote: > This is a little hard to understand. I suggest just using the first sentence > from the description of URLRequest::GetRawBodyBytes(), ie. > > "The size of the response body before removing any content encodings." > > Maybe you could adapt it to the words used in this part of the code, ie. > > "The length of the body before removing any content encodings." > > Since content encodings are always used for compression in practice, I think > > "The length of the body before decompression." > > is okay, although it is a little bit imprecise. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Could you link directly to the design doc from the description? It would save people from having to follow the bug link to find it.
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
On 2016/11/21 09:49:18, Adam Rice wrote: > Could you link directly to the design doc from the description? It would > save people from having to follow the bug link to find it. Done.
lgtm (once Randy's happy)
lgtm
yhirano@chromium.org changed reviewers: + tsepez@chromium.org
+tsepez@ for content/common/resource_messages.h
(I'm still waiting for rdsmith@'s feedback, in case it's not clear.)
On 2016/11/21 03:53:18, yhirano OOO till 11-28 wrote: > > * Could you give pointers to the other CLs in this series so that I can > > understand the context? > Done. > > > * Is there a reason you didn't initialize the new field at all creations of > > ResourceRequestCompletionStatus? (I'm thinking specifically of the one in > > resource_dispatcher_host_impl.cc: AbortRequestBeforeItStarts(), but codesearch > > surfaces some others). > Excluding test related ones, ResourceDispatcherHostImpl and > URLResponseBodyConsumer instantiate the class. For the former case, we should > set 0 as the resource loading is cancelled before starting. Though 0 is the > default value, I added the statement for consistency at PS2. For the latter > case, we don't have to initialize it to a specific value because it will be set > to a value coming from the browser process. Ah, gotcha. I had missed that that class did it's initialization in the declaration; I'm not used to that idiom yet. Still, I'm glad to have the initializations you put in for consistencies sake. LGTM. > > > * What test failure required updated URLRequestFailedJob? > I want to check that different values are set to encoded_data_length and > encoded_body_length in MojoAsyncResourceHandler. URLRequestMockHTTPJob used in > url_laoder_factory_impl_unittest.cc inherits URLRequestFileJob, so the same > value will be set. With the URLRequestFailedJob change, we can distinguish them. > URLLoaderFactoryImplTest::GetFailedResponse2 is the test case checking that.
RS LGTM, browser to renderer message.
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ricea@chromium.org Link to the patchset: https://codereview.chromium.org/2514713002/#ps60001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479850791235850, "parent_rev": "575b456bffe66171c8a04e3f91930cf112d9bcb0", "commit_rev": "9fcd59b5bcc02e50fb889289685465e6e4fc5c7e"}
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2515383004/ by mariakhomenko@chromium.org. The reason for reverting is: I believe this change broke cronet tests: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Mar....
Message was sent while issue was closed.
Feel free to reland this change once you incorporate https://codereview.chromium.org/2526653002/, I'll review it once you've incorporated it.
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} ==========
reopening...
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks, pauljensen@. Can you take a look at PS5?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
components/cronet/ lgtm
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org, ricea@chromium.org, rdsmith@chromium.org, kinuko@chromium.org, tsepez@chromium.org Link to the patchset: https://codereview.chromium.org/2514713002/#ps80001 (title: "merge https://codereview.chromium.org/2526653002/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480325102795490, "parent_rev": "efb7ade8ca82e697aed28bd5420ab8a6c3a72574", "commit_rev": "ead681bca86f82d27dac3f079d0df29343bc7c53"}
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Send encoded_body_length to renderer when response completed (1/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 Cr-Commit-Position: refs/heads/master@{#434032} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/efb9d78772531d0de6900f1f1a213f5cb8b5ebab Cr-Commit-Position: refs/heads/master@{#434624} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/efb9d78772531d0de6900f1f1a213f5cb8b5ebab Cr-Commit-Position: refs/heads/master@{#434624} |