|
|
DescriptionShape Detection: Face detection junit tests
This CL adds two robolectric Junit tests:
- one for SharedBufferUtils, which tests error conditions such
as unmappable buffer, wrong dimensions, or wrong map()ped size
- one for Face Detection, that verifies that the given callback
is called with the appropriate arguments in a series of cases.
This test is parameterized with a boolean indicating fast-mode
or not.
Added alongside the (relatively new) service_junit_tests.
BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed: https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3c355e19a9f3d
Patch Set 1 #
Total comments: 4
Patch Set 2 : scheib@ comments #Patch Set 3 : Increase timeout, because linux_android_rel_ng can be very slow #Patch Set 4 : setFaceDetector() should be a static method (from findBugs) #
Messages
Total messages: 35 (24 generated)
Description was changed from ========== [wip]Shape Detection: Face detection junit tests BUG=718275 ========== to ========== [wip]Shape Detection: Face detection junit tests BUG=718275 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Description was changed from ========== [wip]Shape Detection: Face detection junit tests BUG=718275 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Shape Detection: Face detection junit tests This CL adds two robolectric Junit tests: - one for SharedBufferUtils, which tests error conditions such as unmappable buffer, wrong dimensions, or wrong map()ped size - one for Face Detection, that verifies that the given callback is called with the appropriate arguments in a series of cases. This test is parameterized with a boolean indicating fast-mode or not. Added alongside the (relatively new) service_junit_tests. BUG=718275 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Description was changed from ========== Shape Detection: Face detection junit tests This CL adds two robolectric Junit tests: - one for SharedBufferUtils, which tests error conditions such as unmappable buffer, wrong dimensions, or wrong map()ped size - one for Face Detection, that verifies that the given callback is called with the appropriate arguments in a series of cases. This test is parameterized with a boolean indicating fast-mode or not. Added alongside the (relatively new) service_junit_tests. BUG=718275 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Shape Detection: Face detection junit tests This CL adds two robolectric Junit tests: - one for SharedBufferUtils, which tests error conditions such as unmappable buffer, wrong dimensions, or wrong map()ped size - one for Face Detection, that verifies that the given callback is called with the appropriate arguments in a series of cases. This test is parameterized with a boolean indicating fast-mode or not. Added alongside the (relatively new) service_junit_tests. BUG=722931 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
mcasas@chromium.org changed reviewers: + scheib@chromium.org
scheib@ PTAL
LGTM, some thoughts: https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti... File services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java (right): https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti... services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:77: public void testConstruction() { Just testing that the member variable mFaceDetectionImpl works? https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti... services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:89: SharedBufferHandle handle = Mockito.mock(SharedBufferHandle.class); renaming handle -> sharedBuffer would be clearer.
mcasas@chromium.org changed reviewers: + rockot@chromium.org
rockot@ RS plz (will address scheib@ concerns later on)
rs lgtm
https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti... File services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java (right): https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti... services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:77: public void testConstruction() { On 2017/05/17 00:55:39, scheib wrote: > Just testing that the member variable mFaceDetectionImpl works? Yes, also because |options| in l.60 is parameterized. https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti... services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:89: SharedBufferHandle handle = Mockito.mock(SharedBufferHandle.class); On 2017/05/17 00:55:39, scheib wrote: > renaming handle -> sharedBuffer would be clearer. Done.
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, scheib@chromium.org Link to the patchset: https://codereview.chromium.org/2863773005/#ps160001 (title: "Increase timeout, because linux_android_rel_ng can be very slow")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mcasas@chromium.org
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, scheib@chromium.org Link to the patchset: https://codereview.chromium.org/2863773005/#ps180001 (title: "setFaceDetector() should be a static method (from findBugs)")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495055516399750, "parent_rev": "f134db33d0941e7d89ab862455bf17e0b490fc88", "commit_rev": "5bd36b1f586432d4b127d956a4b3c355e19a9f3d"}
Message was sent while issue was closed.
Description was changed from ========== Shape Detection: Face detection junit tests This CL adds two robolectric Junit tests: - one for SharedBufferUtils, which tests error conditions such as unmappable buffer, wrong dimensions, or wrong map()ped size - one for Face Detection, that verifies that the given callback is called with the appropriate arguments in a series of cases. This test is parameterized with a boolean indicating fast-mode or not. Added alongside the (relatively new) service_junit_tests. BUG=722931 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Shape Detection: Face detection junit tests This CL adds two robolectric Junit tests: - one for SharedBufferUtils, which tests error conditions such as unmappable buffer, wrong dimensions, or wrong map()ped size - one for Face Detection, that verifies that the given callback is called with the appropriate arguments in a series of cases. This test is parameterized with a boolean indicating fast-mode or not. Added alongside the (relatively new) service_junit_tests. BUG=722931 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2863773005 Cr-Commit-Position: refs/heads/master@{#472679} Committed: https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:180001) as https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:180001) has been created in https://codereview.chromium.org/2886943008/ by treib@chromium.org. The reason for reverting is: The news tests are flaky, they've failed in 3 out of 4 runs right now: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests. |