commit | 856c7a000dc46ab16ba3ac5706b480f008e31509 | [log] [tgz] |
---|---|---|
author | Takuto Ikuta <tikuta@chromium.org> | Fri Oct 23 19:49:45 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 23 19:49:45 2020 |
tree | 2e028bd75d84c3fea3cae49380c6fda924247515 | |
parent | 3de51d04f1839c1cbcd5dabaf8d045eeece9606d [diff] |
Revert "[isolate] remove clean_isolated_files step and find_isolated_tests.py" This reverts commit 4a8addf20958de09e66c3d0eec850580ffb54e1a. Reason for revert: https://crbug.com/1140485#c19 Original change's description: > [isolate] remove clean_isolated_files step and find_isolated_tests.py > > This was introduced in https://crrev.com/620703002 and I think this was > necessary for GYP, but we use GN now. > > Leaving isolated files shouldn't effect behavior of other steps. > > Recipe-Manual-Change: build_limited_scripts_slave > Recipe-Nontrivial-Roll: chrome_release > Change-Id: Ie12e2997c4411e92a2756b9a27005576a1553574 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2483726 > Reviewed-by: Junji Watanabe <jwata@google.com> > Commit-Queue: Junji Watanabe <jwata@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> TBR=dpranke@google.com,tikuta@chromium.org,jwata@google.com,yekuang@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140485 Recipe-Nontrivial-Roll: chrome_release Change-Id: I4aa2c683ecd88ce1e8a82c5f0d43f9a7125bd816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2494325 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Junji Watanabe <jwata@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.