commit | e36716b881725c20eb593b4151341f1053400bf2 | [log] [tgz] |
---|---|---|
author | wolenetz <wolenetz@chromium.org> | Thu Aug 27 02:44:16 2015 |
committer | Commit bot <commit-bot@chromium.org> | Thu Aug 27 02:44:51 2015 |
tree | bcac966fbe5c50d05a592dd15b60bcf05a46fbfd | |
parent | b8fc2ca72bfb8a3ce056a0d12eafc42b0165d5a6 [diff] |
Reland of MSE: Verify MediaLog events created by existing MP4 unit tests (patchset #1 id:1 of https://codereview.chromium.org/1306783003/ ) Reason for revert: Relanding this now that the fixed prerequisite CL (https://codereview.chromium.org/1306923004/) has landed. Original issue's description: > Revert of MSE: Verify MediaLog events created by existing MP4 unit tests (patchset #2 id:20001 of https://codereview.chromium.org/1300013002/ ) > > Reason for revert: > Prerequisite CL (https://codereview.chromium.org/1300943002/) is breaking windows bots (http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41148), so reverting both this and it to unblock tree. > > Original issue's description: > > MSE: Verify MediaLog events created by existing MP4 unit tests > > > > Similar to previous changes r342861 and > > https://codereview.chromium.org/1300943002/, this change updates media > > unit tests to provide a StrictMock<MockMediaLog> to verify MediaLog > > events produced with existing MSE MP4 unit tests. While log message > > maintenance burden is increased, helpers are used to reduce that burden > > while gaining improved resilience against logging regression. > > > > This CL does not verify all possible MSE MP4 parser MEDIA_LOGs, just > > those that are emitted by existing unit tests. > > > > TEST=no regression > > > > Committed: https://crrev.com/194a2651ece516dc91fa0da9aa1675afd307e36e > > Cr-Commit-Position: refs/heads/master@{#345183} > > TBR=xhwang@chromium.org,chcunningham@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/61053d4768697c51bad15d7a9bdffa98c591bb7e > Cr-Commit-Position: refs/heads/master@{#345205} TBR=xhwang@chromium.org,chcunningham@chromium.org BUG=524597 Review URL: https://codereview.chromium.org/1317063003 Cr-Commit-Position: refs/heads/master@{#345775}