Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1661723004: [Courgette] Add ELF-ARM test binary. (Closed)

Created:
4 years, 10 months ago by Will Harris
Modified:
4 years, 10 months ago
Reviewers:
huangs
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Courgette] Add ELF-ARM test binary. Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary has a non-code .bad section that if parsed, yields an invalid RVA that fails check later. The commands to create the file are: echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a -mtune=generic-armv7-a - echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section rm a.out bad_section The problematic code is 00000000: 00 20 00 0A => beq loc_00008008 The target RVA (00008008) is valid, but the site RVA (00000000) is bad. BUG=579206 R=huangs@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1cd95ec7f2d52a8152aec6c871b0e9a805eef1b6

Patch Set 1 #

Patch Set 2 : rebase... for no apparent reason #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A courgette/testdata/elf-armv7 View Binary file 0 comments Download

Messages

Total messages: 9 (5 generated)
huangs
LGTM. Thanks!
4 years, 10 months ago (2016-02-03 22:43:37 UTC) #3
huangs
Previous attempt http://crrev.com/1662633002/ got reverted due to weird EXE bit failure that causing presubmit to ...
4 years, 10 months ago (2016-02-03 22:52:07 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1cd95ec7f2d52a8152aec6c871b0e9a805eef1b6 Cr-Commit-Position: refs/heads/master@{#373372}
4 years, 10 months ago (2016-02-03 22:54:28 UTC) #7
Will Harris
4 years, 10 months ago (2016-02-03 22:54:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1cd95ec7f2d52a8152aec6c871b0e9a805eef1b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698