[Courgette] Add ELF-ARM test binary.

[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a -mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true

Committed: https://crrev.com/5dd21d43c6da1cd24f80131811158fada2fc8610
Cr-Commit-Position: refs/heads/master@{#373162}

[huangs, 2016-02-02 21:04:41]

Description was changed from

==========
[Courgette] Add ELF ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The offending code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

to

==========
[Courgette] Add ELF ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

[huangs, 2016-02-02 21:04:41]

huangs@chromium.org changed reviewers:
+ wfh@chromium.org

[huangs, 2016-02-02 21:06:45]

Test case for http://crrev.com/1658463002/. Keeping binary file by itself. Will
add test code in the other CL.  PTAL.

[huangs, 2016-02-02 21:07:42]

Description was changed from

==========
[Courgette] Add ELF ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

[Will Harris, 2016-02-02 21:40:33]

lgtm discussed offline reasons for separate commit. This can go in now, test
will follow.

[huangs, 2016-02-02 21:42:21]

Thanks, submitting!  Will add the test and new fix tomorrow.

[huangs, 2016-02-02 21:42:26]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2016-02-02 21:48:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662633002/1

[commit-bot: I haz the power, 2016-02-02 22:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 22:05:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2016-02-02 22:30:44]

The CQ bit was checked by huangs@chromium.org

[huangs, 2016-02-02 22:30:45]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1662633002/#ps20001
(title: "chmod 750")

[commit-bot: I haz the power, 2016-02-02 22:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662633002/20001

[commit-bot: I haz the power, 2016-02-02 22:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 22:49:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Will Harris, 2016-02-02 22:53:01]

Description was changed from

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true
==========

[Will Harris, 2016-02-02 22:53:09]

On 2016/02/02 22:49:44, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

added NOPRESUBMIT=true

[Will Harris, 2016-02-02 22:53:09]

The CQ bit was checked by wfh@chromium.org

[huangs, 2016-02-02 22:54:56]

Okay.  I was using Windows, using Cygwin chmod.  "git cl patch" on Linux machine
failed for mysterious reason.

[Will Harris, 2016-02-02 22:55:24]

The CQ bit was unchecked by wfh@chromium.org

[Will Harris, 2016-02-02 22:55:47]

Description was changed from

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

[Will Harris, 2016-02-02 22:56:38]

On 2016/02/02 22:54:56, huangs wrote:
> Okay.  I was using Windows, using Cygwin chmod.  "git cl patch" on Linux
machine
> failed for mysterious reason.

oh okay I unchecked then; you do actually need to do this on a linux box.

git cl patch doesn't support binaries, so you basically have to copy the file
across, chmod +x it, then git cl issue 1662633002 to switch to this issue, git
cl upload to push new version, then it should work (phew).

[huangs, 2016-02-03 00:12:49]

Have problem uploading it from Linux; getting

Issue creation errors: {'user': ["You (huangs@google.com) don't own this issue
(1662633002)"]}

Tried to set user.email with "git config --user", didn't change a thing.
Tried to do "git cl upload --email=huangs@chromium.org", also didn't help.

Other people encountered this error message before. However, I can't find
resolution yet.

[huangs (corp), 2016-02-03 01:08:49]

Heh, got upload to work by digging into /depot_tools/third_party/upload.py:
GetRpcServer() and pretend auth_config.use_oauth2 == false.

[huangs (corp), 2016-02-03 01:09:26]

The CQ bit was checked by huangs@google.com

[huangs (corp), 2016-02-03 01:09:26]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1662633002/#ps40001
(title: "Retry from Linux.")

[commit-bot: I haz the power, 2016-02-03 01:11:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662633002/40001

[commit-bot: I haz the power, 2016-02-03 01:24:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 01:24:20]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[huangs, 2016-02-03 03:26:16]

Going to use NOPRESUBMIT=true .

[huangs, 2016-02-03 03:26:26]

Description was changed from

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true
==========

[huangs, 2016-02-03 03:26:35]

The CQ bit was checked by huangs@chromium.org

[huangs, 2016-02-03 03:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1662633002/#ps80001
(title: "Use git update-index --chmod=+x -- on Windows this time.")

[commit-bot: I haz the power, 2016-02-03 03:28:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662633002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662633002/80001

[commit-bot: I haz the power, 2016-02-03 03:51:13]

Description was changed from

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-02-03 03:51:14]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-03 03:52:38]

Description was changed from

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true

Committed: https://crrev.com/5dd21d43c6da1cd24f80131811158fada2fc8610
Cr-Commit-Position: refs/heads/master@{#373162}
==========

[commit-bot: I haz the power, 2016-02-03 03:52:39]

Patchset 5 (id:??) landed as
https://crrev.com/5dd21d43c6da1cd24f80131811158fada2fc8610
Cr-Commit-Position: refs/heads/master@{#373162}

[vabr (Chromium), 2016-02-03 10:26:19]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1663033002/ by vabr@chromium.org.

The reason for reverting is: Broke checkperms, see http://crbug.com/579206#c9..

[huangs, 2016-02-03 15:32:35]

Thanks for reverting this.

I think there's an infrastructure bug regarding EXE bit not being properly
transferred -- or that my setup is wonky.  Investigating.

[huangs, 2016-02-03 16:07:44]

Filed http://crbug.com/583679 .

[huangs, 2016-02-03 21:41:46]

Description was changed from

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true

Committed: https://crrev.com/5dd21d43c6da1cd24f80131811158fada2fc8610
Cr-Commit-Position: refs/heads/master@{#373162}
==========

to

==========
[Courgette] Add ELF-ARM test binary.

Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary
has a non-code .bad section that if parsed, yields an invalid RVA that
fails check latter. The commands to create the file are:

echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a
-mtune=generic-armv7-a -
echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section
arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section
rm a.out bad_section

The problematic code is
00000000: 00 20 00 0A => beq loc_00008008

The target RVA (00008008) is valid, but the site RVA (00000000) is bad.

BUG=579206
NOPRESUBMIT=true

Committed: https://crrev.com/5dd21d43c6da1cd24f80131811158fada2fc8610
Cr-Commit-Position: refs/heads/master@{#373162}
==========

[huangs, 2016-02-03 21:42:07]

Going to retry with "git cl land", this time from Linux.

[huangs, 2016-02-04 15:27:09]

That didn't work.  So wfh@ committed for me in http://crrev.com/1661723004/ . 
Closing issue.